feat: add support for resolving PostContent blocks #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5381c84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
Co-authored-by: Ta5r <[email protected]>
justlevine
force-pushed
the
feat/backporting_populate_post_content_inner_blocks
branch
from
0980c00 to
5381c84
Compare
Contributor
Author
|
Even basing on another branch didn't seem to prevent the merge conflict 🤦 Rebased |
theodesp
approved these changes
Jan 3, 2025
justlevine
deleted the
feat/backporting_populate_post_content_inner_blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for resolving
innerBlocksforcore/post-contentblocks.Important
This PR is based off of #324, which should be merged first.
Relevant diff: 8e2e921
Why
This is essential for supporting FSE, and due to the
final/privatenature ofContentBlocksResolvercannot be easily hooked in from external code.While the WPGraphQL core does not (yet) support querying for a complete FSE template (where
core/post-contentis traditionally used, I believe the above consideration along with the following reasons still make this a good candidate for inclusion:wpgraphql_content_blocks_resolver_content, that goes along with validating the@todoin thePostmodel gate*Note: This PR is based on #324 solely to prevent merge conflicts. There are no code dependencies between the commits.